Tested and passed.snap-2003-09-04

3 files changed, 50 insertions, 33 deletions

diff --git a/ANNOUNCE b/ANNOUNCE
index 7457afb..9e504e6 100644
--- a/ANNOUNCE
+++ b/ANNOUNCE
@@ -1,4 +1,4 @@
-		 PTHREADS-WIN32 SNAPSHOT 2003-09-03

+		 PTHREADS-WIN32 SNAPSHOT 2003-09-04

 		 ----------------------------------

 	 Web Site: http://sources.redhat.com/pthreads-win32/

 	FTP Site: ftp://sources.redhat.com/pub/pthreads-win32

diff --git a/NEWS b/NEWS
index b54defe..04d8483 100644
--- a/NEWS
+++ b/NEWS
@@ -1,43 +1,61 @@
-SNAPSHOT 2003-09-03

+SNAPSHOT 2003-09-04

 -------------------

 

-Bug fixes
+Bug fixes

 ---------
-* pthread_self() would free the newly created implicit POSIX thread handle if
-DuplicateHandle failed instead of recycle it (very unlikely).
+* ptw32_cancelableWait() now allows cancelation of waiting implicit POSIX
+threads.
+
+New test
+--------
+* cancel8.c tests cancelation of Win32 threads waiting at a POSIX cancelation
+point.
+
+
+SNAPSHOT 2003-09-03

+-------------------

+

+Bug fixes

+---------

+* pthread_self() would free the newly created implicit POSIX thread handle if

+DuplicateHandle failed instead of recycle it (very unlikely).

+
+* pthread_exit() was neither freeing nor recycling the POSIX thread struct

+for implicit POSIX threads.

 
-* pthread_exit() was neither freeing nor recycling the POSIX thread struct
-for implicit POSIX threads.
+New feature - Cancelation of/by Win32 (non-POSIX) threads

+---------------------------------------------------------

+Since John Bossom's original implementation, the library has allowed non-POSIX

+initialised threads (Win32 threads) to call pthreads-win32 routines and

+therefore interact with POSIX threads. This is done by creating an on-the-fly

+POSIX thread ID for the Win32 thread that, once created, allows fully

+reciprical interaction. This did not extend to thread cancelation (async or

+deferred). Now it does.

 
-New feature - Cancelation of/by Win32 (non-POSIX) threads
----------------------------------------------------------
-Since John Bossom's original implementation, the library has allowed non-POSIX
-initialised threads (Win32 threads) to call pthreads-win32 routines and
-therefore interact with POSIX threads. This is done by creating an on-the-fly
-POSIX thread ID for the Win32 thread that, once created, allows fully
-reciprical interaction. This did not extend to thread cancelation (async or
-deferred). Now it does.
+Any thread can be canceled by any other thread (Win32 or POSIX) if the former

+thread's POSIX pthread_t value is known. It's TSD destructors and POSIX

+cleanup handlers will be run before the thread exits with an exit code of

+PTHREAD_CANCELED (retrieved with GetExitCodeThread()).

 
-Any thread can be canceled by any other thread (Win32 or POSIX) if the former
-thread's POSIX pthread_t value is known. It's TSD destructors and POSIX
-cleanup handlers will be run before the thread exits with an exit code of
-PTHREAD_CANCELED (retrieved with GetExitCodeThread()).
+This allows a Win32 thread to, for example, call POSIX CV routines in the same way

+that POSIX threads would/should, with pthread_cond_wait() cancelability and

+cleanup handlers (pthread_cond_wait() is a POSIX cancelation point).

 
-This allows a Win32 thread to, for example, call POSIX CV routines in the same way
-that POSIX threads would/should, with pthread_cond_wait() cancelability and
-cleanup handlers (pthread_cond_wait() is a POSIX cancelation point).
+By adding cancelation, Win32 threads should now be able to call all POSIX

+threads routines that make sense including semaphores, mutexes, condition

+variables, read/write locks, barriers, spinlocks, tsd, cleanup push/pop,

+cancelation, pthread_exit, scheduling, etc.

 
-By adding cancelation, Win32 threads should now be able to call all POSIX
-threads routines that make sense including semaphores, mutexes, condition
-variables, read/write locks, barriers, spinlocks, tsd, cleanup push/pop,
-cancelation, pthread_exit, scheduling, etc.
+Note that these on-the-fly 'implicit' POSIX thread IDs are initialised as detached

+(not joinable) with deferred cancelation type. The POSIX thread ID will be created

+automatically by any POSIX routines that need a POSIX handle (unless the routine

+needs a pthread_t as a parameter of course). A Win32 thread can discover it's own

+POSIX thread ID by calling pthread_self(), which will create the handle if

+necessary and return the pthread_t value.

 
-Note that these on-the-fly 'implicit' POSIX thread IDs are initialised as detached
-(not joinable) with deferred cancelation type. The POSIX thread ID will be created
-automatically by any POSIX routines that need a POSIX handle (unless the routine
-needs a pthread_t as a parameter of course). A Win32 thread can discover it's own
-POSIX thread ID by calling pthread_self(), which will create the handle if
-necessary and return the pthread_t value.
+New tests
+---------
+Test the above new feature.
 
 
 SNAPSHOT 2003-08-19

diff --git a/tests/cancel8.c b/tests/cancel8.c
index 632a7e3..fa6b15c 100644
--- a/tests/cancel8.c
+++ b/tests/cancel8.c
@@ -105,7 +105,6 @@ void
 #endif
 Win32thread(void * arg)
 {
-  int i;
   bag_t * bag = (bag_t *) arg;
 
   assert(bag == &threadbag[bag->threadnum]);