Fix potential NULL pointer dereferences.

        Contributed by - "Scott McCaskill" <scott@magruder.org>

        * mutex.c (pthread_mutexattr_init): Return ENOMEM
        immediately and don't dereference the NULL pointer
        if calloc fails.
        (pthread_mutexattr_getpshared): Don't dereference
        a pointer that is possibly NULL.
        * barrier.c (pthread_barrierattr_init): Likewise
        (pthread_barrierattr_getpshared): Don't dereference
        a pointer that is possibly NULL.
        * condvar.c (pthread_condattr_getpshared): Don't dereference
        a pointer that is possibly NULL.

1 files changed, 6 insertions, 10 deletions

diff --git a/barrier.c b/barrier.c
index fa52cbf..3cfa66f 100644
--- a/barrier.c
+++ b/barrier.c
@@ -221,13 +221,14 @@ pthread_barrierattr_init (pthread_barrierattr_t * attr)
     {
       result = ENOMEM;
     }
- 
-  ba->pshared = PTHREAD_PROCESS_PRIVATE;
- 
+  else
+    {
+      ba->pshared = PTHREAD_PROCESS_PRIVATE;
+    }
+
   *attr = ba;
- 
+
   return (result);
- 
 }                               /* pthread_barrierattr_init */
  
  
@@ -270,12 +271,9 @@ pthread_barrierattr_destroy (pthread_barrierattr_t * attr)
  
       *attr = NULL;
       free (ba);
- 
-      result = 0;
     }
  
   return (result);
- 
 }                               /* pthread_barrierattr_destroy */
 
 
@@ -330,12 +328,10 @@ pthread_barrierattr_getpshared (const pthread_barrierattr_t * attr,
     }
   else
     {
-      *pshared = PTHREAD_PROCESS_PRIVATE;
       result = EINVAL;
     }
  
   return (result);
- 
 }                               /* pthread_barrierattr_getpshared */