Clarify behaviour and remove some redundant code - see ChangeLogs

1 files changed, 84 insertions, 40 deletions

diff --git a/ChangeLog b/ChangeLog
index fbb0aee..7ce169c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,59 +1,103 @@
-2004-07-01  Anuj Goyal  <anuj.goyal at gmail.com>
+2004-09-09  Tristan Savatier  <tristan at mpegtv.com>

+	* pthread.h (struct pthread_once_t_): Qualify the 'done' element
+	as 'volatile'.
+	* pthread_once.c: Concerned about possible race condition,
+	specifically on MPU systems re concurrent access to multibyte types.
+	[Maintainer's note: the race condition is harmless on SPU systems
+	and only a problem on MPU systems if concurrent access results in an
+	exception (presumably generated by a hardware interrupt). There are
+	other instances of similar harmless race conditions that have not been
+	identified as issues.]
 
-	* builddmc.bat: New; Windows bat file to build the library.
-	* config.h (__DMC__): Support for Digital Mars compiler.
-	* create.c (__DMC__): Likewise.
-	* pthread_exit.c (__DMC__): Likewise.
-	* pthread_join.c (__DMC__): Likewise.
-	* ptw32_threadDestroy.c (__DMC__): Likewise.
-	* ptw32_threadStart.c (__DMC__): Likewise.
-	* ptw32_throw.c (__DMC__): Likewise.
+2004-09-09  Ross Johnson  <rpj at callisto.canberra.edu.au>

 
-2004-06-29  Anuj Goyal  <anuj.goyal at gmail.com>
+	* pthread.h: Declare additional types as volatile.
 
-	* pthread.h (__DMC__): Initial support for Digital Mars compiler.
+2004-08-27  Ross Johnson  <rpj at callisto.canberra.edu.au>

 
-2004-06-29  Will Bryant  <will.bryant at ecosm.com>
+	* pthread_barrier_wait.c (pthread_barrier_wait): Remove excessive code
+	by substituting the internal non-cancelable version of sem_wait
+	(ptw32_semwait).
 
-	* README.Borland: New; description of Borland changes.
-	* Bmakefile: New makefile for the Borland make utility.
-	* ptw32_InterlockedCompareExchange.c:
-	Add Borland compatible asm code.
+2004-08-25  Ross Johnson  <rpj at callisto.canberra.edu.au>

 
-2004-06-26  Jason Bard  <BardJA at Npt.NUWC.Navy.Mil>
+	* pthread_join.c (pthread_join): Rewrite and re-order the conditional

+	tests in an attempt to improve efficiency and remove a race

+	condition.

 
-	* pthread.h (HAVE_STRUCT_TIMESPEC): If undefined, define it
-	to avoid timespec struct redefined errors elsewhere in an
-	application.
+2004-08-23  Ross Johnson  <rpj at callisto.canberra.edu.au>

 
-2004-06-21  Ross Johnson  <rpj at callisto.canberra.edu.au>
+	* create.c (pthread_create): Don't create a thread if the thread

+	id pointer location (first arg) is inaccessible. A memory

+	protection fault will result if the thread id arg isn't an accessible

+	location. This is consistent with GNU/Linux but different to

+	Solaris or MKS (and possibly others), which accept NULL as meaning

+	'don't return the created thread's ID'. Applications that run

+	using pthreads-win32 will run on all other POSIX threads

+	implementations, at least w.r.t. this feature.

 
-	* pthread.h (PTHREAD_RECURSIVE_MUTEX_INITIALIZER): Mutex
-	initialiser added for compatibility with Linux threads and
-	others; currently not included in SUSV3.
-	* pthread.h (PTHREAD_ERRORCHECK_MUTEX_INITIALIZER): Likewise.
-	* pthread.h (PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP): Likewise.
-	* pthread.h (PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP): Likewise.
+	It was decided not to copy the Solaris et al behaviour because,

+	although it would have simplified some application porting (but only

+	from Solaris to Windows), the feature is not technically necessary,

+	and the alternative segfault behaviour helps avoid buggy application

+	code.

 
-	* ptw32_mutex_check_need_init.c (ptw32_mutex_check_need_init): 
-	Add new initialisers.
+2004-07-01  Anuj Goyal  <anuj.goyal at gmail.com>

 
-	* pthread_mutex_lock.c (pthread_mutex_lock): Check for new
-	initialisers.
-	* pthread_mutex_trylock.c (pthread_mutex_trylock): Likewise.
-	* pthread_mutex_timedlock.c (pthread_mutex_timedlock): Likewise.
-	* pthread_mutex_unlock.c (pthread_mutex_unlock): Likewise.
-	* pthread_mutex_destroy.c (pthread_mutex_destroy): Likewise.
+	* builddmc.bat: New; Windows bat file to build the library.

+	* config.h (__DMC__): Support for Digital Mars compiler.

+	* create.c (__DMC__): Likewise.

+	* pthread_exit.c (__DMC__): Likewise.

+	* pthread_join.c (__DMC__): Likewise.

+	* ptw32_threadDestroy.c (__DMC__): Likewise.

+	* ptw32_threadStart.c (__DMC__): Likewise.

+	* ptw32_throw.c (__DMC__): Likewise.

 
-2004-05-20  Ross Johnson  <rpj at callisto.canberra.edu.au>
+2004-06-29  Anuj Goyal  <anuj.goyal at gmail.com>

 
-	* README.NONPORTABLE: Document pthread_win32_test_features_np().
-	* FAQ: Update various answers.
+	* pthread.h (__DMC__): Initial support for Digital Mars compiler.

+
+2004-06-29  Will Bryant  <will.bryant at ecosm.com>

+
+	* README.Borland: New; description of Borland changes.

+	* Bmakefile: New makefile for the Borland make utility.

+	* ptw32_InterlockedCompareExchange.c:

+	Add Borland compatible asm code.

+
+2004-06-26  Jason Bard  <BardJA at Npt.NUWC.Navy.Mil>

+
+	* pthread.h (HAVE_STRUCT_TIMESPEC): If undefined, define it

+	to avoid timespec struct redefined errors elsewhere in an

+	application.

+
+2004-06-21  Ross Johnson  <rpj at callisto.canberra.edu.au>

+
+	* pthread.h (PTHREAD_RECURSIVE_MUTEX_INITIALIZER): Mutex

+	initialiser added for compatibility with Linux threads and

+	others; currently not included in SUSV3.

+	* pthread.h (PTHREAD_ERRORCHECK_MUTEX_INITIALIZER): Likewise.

+	* pthread.h (PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP): Likewise.

+	* pthread.h (PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP): Likewise.

+
+	* ptw32_mutex_check_need_init.c (ptw32_mutex_check_need_init): 

+	Add new initialisers.

+
+	* pthread_mutex_lock.c (pthread_mutex_lock): Check for new

+	initialisers.

+	* pthread_mutex_trylock.c (pthread_mutex_trylock): Likewise.

+	* pthread_mutex_timedlock.c (pthread_mutex_timedlock): Likewise.

+	* pthread_mutex_unlock.c (pthread_mutex_unlock): Likewise.

+	* pthread_mutex_destroy.c (pthread_mutex_destroy): Likewise.

+
+2004-05-20  Ross Johnson  <rpj at callisto.canberra.edu.au>

+
+	* README.NONPORTABLE: Document pthread_win32_test_features_np().

+	* FAQ: Update various answers.

 
 2004-05-19  Ross Johnson  <rpj at callisto.canberra.edu.au>

 
-	* Makefile: Don't define _WIN32_WINNT on compiler command line.
-	* GNUmakefile: Likewise.
+	* Makefile: Don't define _WIN32_WINNT on compiler command line.

+	* GNUmakefile: Likewise.

 
 2004-05-16  Ross Johnson  <rpj at callisto.canberra.edu.au>