Reuse of thread IDs, improved thread ID validation, new tests, bug fixes.

1 files changed, 15 insertions, 5 deletions

diff --git a/pthread_detach.c b/pthread_detach.c
index 423997d..a54a7e8 100644
--- a/pthread_detach.c
+++ b/pthread_detach.c
@@ -38,9 +38,15 @@
 #include "pthread.h"
 #include "implement.h"
 
+/*
+ * Not needed yet, but defining it should indicate clashes with build target
+ * environment that should be fixed.
+ */
+#include <signal.h>
+
 
 int
-pthread_detach (pthread_t tid)
+pthread_detach (pthread_t thread)
      /*
       * ------------------------------------------------------
       * DOCPUBLIC
@@ -70,17 +76,21 @@ pthread_detach (pthread_t tid)
 {
   int result;
 
-  if (tid == NULL ||
-      tid->detachState == PTHREAD_CREATE_DETACHED)
+  /* This is the proper way to test for a valid thread. */
+  result = pthread_kill(thread, 0);
+  if (0 != result)
     {
+      return result;
+    }
 
+  if (thread->detachState == PTHREAD_CREATE_DETACHED)
+    {
       result = EINVAL;
-
     }
   else
     {
       result = 0;
-      tid->detachState = PTHREAD_CREATE_DETACHED;
+      thread->detachState = PTHREAD_CREATE_DETACHED;
     }
 
   return (result);